Re: [PATCH] ftrace: add an fsync tracer

[Ingo Molnar]

* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> > > +	buffer = kmalloc(4096, GFP_KERNEL);

> > > +	err = d_path(&file->f_path, buffer, 4096);

hm, magic constants.

> > > +	if (IS_ERR(err))
> > > +		goto out;
> > > +
> > > +	ftrace_printk("Process %s is calling fsync on %s\n",
> > > +			current->comm, err);
> > 
> > err? not buffer?
> 
> correct, not buffer
> 
> it won't work if you use buffer.

please use some other name than 'err' - since "error" is just a 
property of the path string pointer you get back from do_path().

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/