Re: [PATCH] input: Add a detailed multi-touch finger data reportprotocol

[Henrik Rydberg]

[..]

>> BTN_MT_REPORT_PACKET
[..]
>> BTN_MT_REPORT_FINGER
> 
> Hmm, why not use a new event type to report multi-touch data? I find the use
> of fake buttons here kind of ugly.

Good point, I will revise.

>> +#define ABS_MT_TOUCH		0x30	/* Diameter of touching circle */
>> +#define ABS_MT_TOUCH_MAJOR	0x30	/* Major axis of touching ellipse */
>> +#define ABS_MT_TOUCH_MINOR	0x31	/* Minor axis of touching ellipse */
>> +#define ABS_MT_WIDTH		0x32	/* Diameter of approaching circle */
>> +#define ABS_MT_WIDTH_MAJOR	0x32	/* Major axis of approaching ellipse */
>> +#define ABS_MT_WIDTH_MINOR	0x33	/* Minor axis of approaching ellipse */
>> +#define ABS_MT_ORIENTATION	0x34	/* Ellipse orientation */
>> +#define ABS_MT_POSITION_X	0x35	/* Center X ellipse position */
>> +#define ABS_MT_POSITION_Y	0x36	/* Center Y ellipse position */
> 
> Does your hardware provide all this data, or do you want to do the
> calculations for these numbers in a kernel driver?

These are all numbers directly from the bcm5974 USB interface. There is
no computation involved.

> Isn't it much easier to
> do these kind of calculations in user space where you can make liberal use
> of floating point numbers?

For chips that cannot produce the above events, one simply reports less data.
If orientation data cannot be obtained, leave out TOUCH_MINOR, WIDTH_MINOR
and ORIENTATION. If finger width cannot be obtained, leave out WIDTH. The
minimum set of data is TOUCH, POSITION_X and POSITION_Y. If touch pressure
information is not given in trackpad dimension units, use a specific range.
I believe all current drivers are able to produce this data.

> In other words, are you not overdesigning this interface or targetting it
> too much to some specific hardware you have in mind?

It is designed to bring advanced gestures to the linux desktop. It can be
implemented on different levels depending on hardware capabilities.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/