Re: [patch] add /proc/pid/stack to dump task's stack trace

[Ingo Molnar]

* Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> >  1) only root should be allowed to do this - i.e. file needs to be 
> >     root-owned.
> >
> >  2) there also needs to be a .config entry for folks to be able to
> >     turn it off altogether - just like folks can turn off sysrq-t 
> >     dumping via the .config.
> 
> In the name of everything holy, don't add another config option. 
> It's a _tiny_ piece of code and you have select STACKTRACE via fault 
> injection, latencytop or lockdep before that.

We could make it depend on DEBUG_KERNEL or so, and always select 
STACKTRACE infrastructure when DEBUG_KERNEL is enabled? There's no 
reason not to get high quality backtraces via /proc when one debugs 
the kernel.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/