Re: [PATCH] cpumask: introduce new API, without changing anything

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Friday 07 November 2008 23:24:00 Ingo Molnar wrote:
> > Find below the delta patch between the two versions, and an
> > analysis/review of the changes. I've started testing it as well, and
> > it's looking good so far.
> 
> Ok, I sent through the latest delta on top of this before, but see below.
> 
> > - the cpumask_of() is added to the SMP section of cpumask.h but not to
> >   the UP section.
> 
> Not quite: it's in the general section.  Don't scare me like that :)

heh, indeed - i looked twice and both times i missed this in the 
middle of that code:

 #endif /* SMP */

... sorry, my bad! (a newline before this line might have helped)

> > - the free_bootmem_cpumask_var() addition looks good but is a tiny bit
> >   incomplete: the free_bootmem_cpumask_var() function should be marked
> >   __init, like all bootmem methods are.
> 
> Looks like you took that draft I mailed around?  Mike asked for 
> free_... as a response to that.  But I'll fix the __init.
> 
> I've restored the patch into that version you have, plus separate 
> updates.  I hope that fixes the workflow issues.
> 
> Updates below for reference.

thanks a ton, this looks perfect.

Mike, could you please double-check that the version that is in 
tip/cpus4096 [622e0ed] is the final version you need, and that if you 
base subsequent patches on it it works as expected?

Then it would be all green and Rusty could send the final version of 
the patch to Linus. It has my ack obviously:

  Acked-by: Ingo Molnar <mingo@xxxxxxx>

and once that patch hits upstream, we could restructure/rebase the 
commits in cpus4096-v2 ontop of upstream and spread them out properly. 
Does that sound optimal?

Thomas also did a cross-build of it, and it looks all good:

   Run 141: 2008-11-07 13:54:41 .. 2008-11-07 15:02:59

   Run 141: 17 of 19 operations OK
   Run 141: 2 of 19 operations FAILED

   http://www.tglx.de/autoqa-logs/000141-0008-0005.log
   http://www.tglx.de/autoqa-logs/000141-0008-0015.log

the two build failures are not related to these changes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/