Re: [TOMOYO #12 (2.6.28-rc2-mm1) 06/11] Common functions forTOMOYOLinux.

[Serge E. Hallyn]

Quoting Tetsuo Handa (penguin-kernel@xxxxxxxxxxxxxxxxxxx):
> Hello.
> 
> Andrew Morton wrote:
> > > +static bool is_select_one(struct tmy_io_buffer *head, const char *data)
> > > +{
> > > +	unsigned int pid;
> > > +	struct domain_info *domain = NULL;
> > > +
> > > +	if (sscanf(data, "pid=%u", &pid) == 1) {
> > 
> > PIDs are no longer system-wide unique, and here we appear to be
> > implementing new userspace ABIs using PIDs.
> > 
> I'm not familiar with virtualized environment.
> 
> There are two PIDs, PID seen from inside virtualized environment and
> PID seen from outside virtualized environment. To clarify, let me call
> the former "PIDv" and the latter "PIDg".
> 
> PIDv is not system-wide unique. But PIDg is system-wide unique, aren't they?
> The PID received from outside virtualized environment is PIDg and they are
> system-wide unique, am I right?

You are doing find_task_by_vpid(), so you are not looking up a task by
global pid.

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/