Re: [PATCH] fix smp generic helper voyager breakage

From: Yinghai Lu
Date: Mon Nov 10 2008 - 04:41:56 EST


On Mon, Nov 10, 2008 at 1:35 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
>> From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Wed, 29 Oct 2008 14:53:06 -0500
>> Subject: [VOYAGER] fix generic smp helpers non compile
>
> hm, i reported a bug to you with this patch on Oct 30.
>
>> commit 3d4422332711ef48ef0f132f1fcbfcbd56c7f3d1
>> Author: Jens Axboe <jens.axboe@xxxxxxxxxx>
>> Date: Thu Jun 26 11:21:34 2008 +0200
>>
>> Add generic helpers for arch IPI function calls
>>
>> didn't wire up the voyager smp call function correctly, so do that
>> here. Also make CONFIG_USE_GENERIC_SMP_HELPERS a def_bool y again,
>> since we now use the generic helpers for every x86 architecture.
>>
>> Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>> arch/x86/Kconfig | 5 ++++-
>> arch/x86/mach-voyager/voyager_smp.c | 16 ++++++++++++++--
>> 2 files changed, 18 insertions(+), 3 deletions(-)
>
> no indication in the changelog whether that bug i reported got fixed -
> did it? (i suspect it did, but not sure)

should fix some voyager_smp.c compliing...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/