Re: [PATCH] power_supply: Add support for WM8350 PMU

[Mark Brown]

On Mon, Nov 10, 2008 at 03:43:30PM -0800, Andrew Morton wrote:
> Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> An idle question...

[Reordered for conveninece in replying.]

> The above constitutes a sort-of userspace interface.  A number of the
> things which are being reported there are fairly common to the
> technology and other drivers will be able to report them.

> But afaict this interface is unique to this particular driver.  Has any
> thought been given to standardising this interface across all similar
> drivers?  Too messy?

I've got several answers...

> > +		supply = "Battery";
> > +		supply = "USB";
> > +		supply = "Line";
> > +		supply = "Battery and USB";

This sysfs file is just redundant and could be removed.

> > +		charge = "Charger Off";
> > +		charge = "Trickle Charging";
> > +		charge = "Fast Charging";

There's some support for this already (which implemented in the driver)
but it doesn't distinguish between fast and trickle charging.  It's
useful to know for debugging systems but I wasn't able to convince
myself it was generically useful enough to add to the class ABI,
especially given the existing boolean reporting.

> > +		dev_err(wm8350->dev, "battery too hot\n");
> > +		dev_err(wm8350->dev, "battery too cold\n");
> > +		dev_err(wm8350->dev, "battery failed\n");
> > +		dev_err(wm8350->dev, "charger timeout\n");

These are a bit tricky with the WM8350 since the chip gives latched edge
notifications of errors but doesn't provide the current status directly.
There is some generic battery health status reporting in the interface
(though not quite so specific) but I wasn't comfortable supporting it
without being able to read back the current status.

> > +		dev_dbg(wm8350->dev, "charger stopped\n");
> > +		dev_dbg(wm8350->dev, "charger started\n");
> > +		dev_dbg(wm8350->dev, "fast charger ready\n");

On a closer look it appears that started and stopped are already
notified to user space - the driver should be calling
power_supply_changed() when these happen.  Reporting the fast charger
ready status would fall out if a standard interface for polling this
status were implemented.

> > +		dev_warn(wm8350->dev, "battery < 3.9V\n");
> > +		dev_warn(wm8350->dev, "battery < 3.1V\n");
> > +		dev_warn(wm8350->dev, "battery < 2.85V\n");

I'm ambivalent on these ones, especially given that none of the other
health issues are being reported.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/