Re: [PATCH] Fix argument type for acpi_evaluate_integer inacpi_get_physical_pci_device

[Andrew Morton]

On Mon, 3 Nov 2008 12:16:13 +0300
Andrey Borzenkov <arvidjaar@xxxxxxx> wrote:

> Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> From: Andrey Borzenkov <arvidjaar@xxxxxxx>
> 
> CC      drivers/acpi/glue.o
> /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
> 
> acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
> 
> Signed-off-by: Andrey Borzenkov <arvidjaar@xxxxxxx>
> 
> ---
> 
>  drivers/acpi/glue.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> index 98c9c76..436c8a3 100644
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
>  struct device *acpi_get_physical_pci_device(acpi_handle handle)
>  {
>  	struct device *dev;
> -	long device_id;
> +	unsigned long long device_id;
>  	acpi_status status;
>  
>  	status =

Someone has gone and changed this to `long long', which is still wrong
but which (surprisingly) doesn't seem to generate a compilation
warning.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/