Re: [PATCH 3/4] add ksm kernel shared memory driver

From: Avi Kivity
Date: Tue Nov 11 2008 - 17:43:34 EST


Jonathan Corbet wrote:
+static struct list_head slots;

Some of these file-static variable names seem a little..terse...

While ksm was written to be independent of a certain TLA-named kernel subsystem developed two rooms away, they share some naming... this refers to kvm 'memory slots' which correspond to DIMM banks.

I guess it should be renamed to merge_ranges or something.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/