Re: [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3)

[KAMEZAWA Hiroyuki]

On Tue, 11 Nov 2008 18:04:17 +0530
Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> +
> +		/*
> +		 * We need to give up the cgroup lock if it is held, since
> +		 * it creates the potential for deadlock. cgroup_mutex should
> +		 * be acquired after cpu_hotplug lock. In this path, we
> +		 * acquire the cpu_hotplug lock after acquiring the cgroup_mutex
> +		 * Giving it up should be OK
> +		 */
> +		if (cgroup_locked)
> +			cgroup_unlock();

nice catch. I'll post a fix to this as its own patch. 

Thanks,
-Kame


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/