Re: [PATCH][mmotm] Sched fix stale value in average load per task

[Balbir Singh]

Ingo Molnar wrote:
> * Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> 
>> cpu_avg_load_per_task() returns a stale value when nr_running is 0. 
>> It returns an older stale (caculated when nr_running was non zero) 
>> value. This patch returns and sets rq->avg_load_per_task to zero 
>> when nr_running is 0.
>>
>> Compile and boot tested on a x86_64 box.
>>
>> Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
>> ---
>>
>>  kernel/sched.c |    2 ++
>>  1 file changed, 2 insertions(+)
> 
> applied to tip/sched/urgent, thanks Balbir!
> 
> i'm wondering, have you observed load-balancer misbehavior due to this 
> load-average imprecision bug, on some workload? (or have you found 
> this via code review)


Thanks, Ingo!

I found this issue through code review. I did not see any misbehaviour yet due
to load-average imprecision.


-- 
	Balbir

PS: FYI: I missed this email, since my name was missing in the to and cc list.
Could you check to see if there is any issue with your mailer, I'll do the same.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/