Re: [RFC] Add PR_PREFIX to pr_xyz macros.

[Martin Schwidefsky]

On Wed, 2008-11-12 at 11:48 -0800, Linus Torvalds wrote:
> 
> On Wed, 12 Nov 2008, Martin Schwidefsky wrote:
> >
> > +#ifndef PR_PREFIX
> > +#define pr_fmt(format) format 
> > +#else
> > +#define pr_fmt(format) PR_PREFIX ": " format
> > +#endif
> > +
> > +#define pr_emerg(fmt, ...) \
> > +        printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
> 
> So, why can't people just define their pr_fmt() macro directly, something 
> like
> 
> 	#define pr_fmt(fmt) \
> 		"%s:%d " fmt, __FILE__, __LINE__
> 
> which seems to be much more useful and generic than forcing them to use 
> "PR_PREFIX"?

Even better - much better. With that define a lot more printk wrappers
could be replaced. I'll come up with a patch.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/