Re: [PATCH 2/6] ide: remove chipset type fixup from ide_host_register()

From: Sergei Shtylyov
Date: Wed Nov 12 2008 - 17:50:29 EST


Hello.

Bartlomiej Zolnierkiewicz wrote:

* Set chipset type explicitly in tx4938ide and tx4939ide host drivers
(all other host drivers were updated already).

* Remove no longer used chipset type fixup from ide_host_register().

CC: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
[...]
Index: b/drivers/ide/tx4938ide.c
===================================================================
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -226,6 +226,7 @@ static const struct ide_port_info tx4938
#endif
.host_flags = IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,
.pio_mask = ATA_PIO5,
+ .chipset = ide_generic,
};
static int __init tx4938ide_probe(struct platform_device *pdev)
Index: b/drivers/ide/tx4939ide.c
===================================================================
--- a/drivers/ide/tx4939ide.c
+++ b/drivers/ide/tx4939ide.c
@@ -644,6 +644,7 @@ static const struct ide_port_info tx4939
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA5,
+ .chipset = ide_generic,

I'm not really sure those are "generic".

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/