Re: [PATCH 1/1] ftrace: do not update max buffer with no users

[Steven Rostedt]

On Wed, 12 Nov 2008, Andrew Morton wrote:
> 
> 
> This sort of thing:
> 
> +#ifdef CONFIG_TRACER_MAX_TRACE
>  	if (current_trace && current_trace->print_max)
>  		iter->tr = &max_tr;
>  	else
> +#endif
>  		iter->tr = inode->i_private;
> 
> is particularly regrettable.

Another answer is to not allocate it and check for NULL before using it. 
But this would mean that I would have to find all the places that touch it 
(the same as the ifdefs) and make sure they are safe.

The reason I picked the ifdefs was to guarantee that there were no users 
if it was not being used.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/