Re: [patch 02/17] get_cycles() : x86 HAVE_GET_CYCLES

[Geert Uytterhoeven]

On Wed, 12 Nov 2008, Mathieu Desnoyers wrote:
> --- linux.trees.git.orig/arch/x86/include/asm/tsc.h	2008-11-12 18:15:25.000000000 -0500
> +++ linux.trees.git/arch/x86/include/asm/tsc.h	2008-11-12 18:15:28.000000000 -0500
> @@ -56,6 +56,18 @@ extern void mark_tsc_unstable(char *reas
>  extern int unsynchronized_tsc(void);
>  int check_tsc_unstable(void);
>  
> +static inline cycles_t get_cycles_rate(void)
> +{
> +	if (check_tsc_unstable())
> +		return 0;
> +	return tsc_khz;
                   ^^^

The comment in Kconfig says:

| get_cycles_rate() : cycle counter rate, in HZ
                                             ^^

So what should it be? Hz or kHz?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/