Re: [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3)

[Balbir Singh]

KAMEZAWA Hiroyuki wrote:
> On Wed, 12 Nov 2008 16:51:41 +0530
> Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> 
> 
>> Here is the iterative version of this patch. I tested it in my
>> test environment. NOTE: The cgroup_locked check is still present, I'll
>> remove that shortly after your patch is accepted.
>>
>> This patch introduces hierarchical reclaim. When an ancestor goes over its
>> limit, the charging routine points to the parent that is above its limit.
>> The reclaim process then starts from the last scanned child of the ancestor
>> and reclaims until the ancestor goes below its limit.
>>
> 
> complicated as you said but it seems it's from style.
> 
> I expected following kind of one.

Thanks, it looks very similar to what I have, I like the split of the iterator,
start token and next token. I'll refactor the code based on your suggestion if
possible in the next version.

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/