Re: [PATCH] HID: don't grab devices with no input

From: Jiri Slaby
Date: Thu Nov 13 2008 - 17:05:32 EST


On 11/13/2008 10:37 PM, Alan Stern wrote:
>> + for (n = 0; n < interface->desc.bNumEndpoints; n++)
>> + if (usb_endpoint_dir_in(&interface->endpoint[n].desc))
>> + has_in++;
>> + if (!has_in) {
>> + dev_err(&intf->dev, "couldn't find an input interrupt "
>> + "endpoint");
>> + return -ENODEV;
>> + }
>> +
>
> Do you want to use usb_endpoint_is_int_in() instead? It matches the
> error message more closely.

Yes, good catch, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/