Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined

[Takashi Iwai]

At Thu, 13 Nov 2008 20:03:39 +0100,
Ingo Molnar wrote:
> 
> 
> * Andres Salomon <dilinger@xxxxxxxxxx> wrote:
> 
> > On Thu, 13 Nov 2008 17:38:02 +0100
> > Pavel Machek <pavel@xxxxxxx> wrote:
> > 
> > > On Thu 2008-11-13 11:14:28, Andres Salomon wrote:
> > > > On Thu, 13 Nov 2008 16:54:19 +0100
> > > > Takashi Iwai <tiwai@xxxxxxx> wrote:
> > > > 
> > > > > At Thu, 13 Nov 2008 16:37:14 +0100,
> > > > > Pavel Machek wrote:
> > > > [...]
> > > > > > 
> > > > > > > IMO, the basic problem is rather that the platform and the CPU
> > > > > > > selection is mixed up.  The geode GPIO stuff shouldn't belong
> > > > > > > to CPU selection.
> > > > > > 
> > > > > > ACK... and suggested patch makes it worse.
> > > > > > 
> > > > > > There should be option 'support OLPC' somewhere, and that should
> > > > > > enable the gpio bits. Alsa driver should depend on that one.
> > > > > 
> > > > > Any better fix patch is welcome, of course :)
> > > > > This would make save a lot time than writing mails...
> > > 
> > > > 
> > > > Okay, how about something like the following?
> > > 
> > > It is wrong. It is valid & useful to compile kernel for i386 and
> > > expect all the features on OLPC (with small performance hit).
> > 
> > No one's debating that.  That requires additional work that will 
> > take longer, however.
> 
> i've zapped this patch meanwhile:
> 
>  1355c96: x86/olpc: make CONFIG_OLPC dependent on CONFIG_MGEODE_LX
> 
> because it cripples the ability to run distribution kernels on the 
> OLPC.

OK, I reverted also all relevant changes for cs5535audio driver now.
The patches are saved in topic/cs5535audio branch, though.

Let's fix OLPC-geode coupling first.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/