Re: [PATCH] Fix an uninitialised variable warning in the 8250driver

[Alan Cox]

On Fri, 14 Nov 2008 16:20:38 +0000
David Howells <dhowells@xxxxxxxxxx> wrote:

> Fix an uninitialised variable warning in the 8250 driver:
> 
>   CC      drivers/serial/8250.o
> drivers/serial/8250.c: In function 'serial8250_shutdown':
> drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this function

Current versions of gcc that I've tested get this all correct just fine
for x86 at least.

Do check that the BUG_ON() helper for whatever platform you are using
needs to correctly indicate that its BUG spewing path may not return
(__attibute((__noreturn__)). I seem to remember some of the architectures
are broken on that.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/