Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto ops on keys

From: Leon Woestenberg
Date: Fri Nov 14 2008 - 11:50:13 EST


Hello,

On Fri, Nov 14, 2008 at 5:40 PM, Michael Halcrow <mhalcrow@xxxxxxxxxx> wrote:
>
> - sg_init_table(&dst_sg, 1);
> - sg_init_table(&src_sg, 1);

Why did you remove the inits?

With self-checking enabled in the kernel, sg accessor functions will
check on proper initialization and BUGON().

It might be your use-case would not hit this, as it seems not to use
sg_ macro's much.

Regards,
--
Leon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/