Re: [PATCH 0/2] question

From: Greg KH
Date: Fri Nov 14 2008 - 13:40:41 EST


On Fri, Nov 14, 2008 at 08:23:59PM +0800, Qinghuang Feng wrote:
> sorry that the patch-send-tool coded by me had a bug, so the former
> patches can't be sent to maillist. Now, the bug has fixed I think,
> so I resend them again :)
>
> And I have a question, should all the init(exit) functions in a module
> be marked as __init(__exit)?

Probably, yes, they should.

> please ignore the following, it used to bypass my tool's
> checking temporarily.

I think you need to fix your tool :)

You do know that git-send-email will probably do all that you need here,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/