Re: [PATCH] Fix an uninitialised variable warning in the 8250driver

[Alan Cox]

On Fri, 14 Nov 2008 16:51:08 +0000
David Howells <dhowells@xxxxxxxxxx> wrote:

> Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Current versions of gcc that I've tested get this all correct just fine
> > for x86 at least.
> 
> gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)

Newer gcc (4.3 and above) gets it right.

> x86_64 - which doesn't do that.  It uses asm volatile and an infinite for-loop.

Which it seems 4.3 knows about

> Surely having BUG() retreat through a noreturn function may lose important
> state, such as the function that issued the bug as the compiler is under no
> requirement to save the return value, and the file/line info may not be
> available.

Its arch specific code so arch specific things can be done.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/