Re: [GIT PATCH] USB patches for 2.6-git

From: Sergei Shtylyov
Date: Fri Nov 14 2008 - 14:41:00 EST


Hello.

Greg KH wrote:

Hi Greg,

There is a difference in the musb patch I submitted and the one which actually has been
forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb: musb: fix bug in musb_schedule".

thanks,
greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/