Re: [PATCH] leds: Fix locking for WM8350

From: Mark Brown
Date: Sat Nov 15 2008 - 14:15:16 EST


On Sat, Nov 15, 2008 at 07:51:20PM +0100, Pavel Machek wrote:
> On Sat 2008-11-15 17:50:50, Mark Brown wrote:

> > Yes, that'd be safer though I'd be surprised to see systems that could
> > trigger it.

> Yes, they are uncommon. They exist; SPARC, IIRC. Plus you need

Exceptionally uncommon with the systems the WM8350 gets used with -
it's a primary PMIC for mobile devices so anything other than
uniprocessor ARM would be surprising.

> barriers on anything SMP... Just use atomic_t.

I was intending to do so next time I spin the patch. Andrew had some
other comments and I don't have any test systems when I'm not in the
office anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/