Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatusvalue
From: Ingo Molnar
Date: Fri Nov 21 2008 - 03:24:24 EST
nice fix! A few minor nits:
> + /* a workaround for family 11h erratum 311 might cause
> + an "out-of-range Pstate if the core is in Pstate-0 */
Please use the customary comment style:
/*
* Comment .....
* ...... goes here:
*/
and since it's multi-line anyway, keep to the 80-col limit too please.
> diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> index ab48cfe..4078f5d 100644
> --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> @@ -23,7 +23,9 @@ struct powernow_k8_data {
> u32 exttype; /* extended interface = 1 */
>
> /* keep track of the current fid / vid or pstate */
> - u32 currvid, currfid, currpstate;
> + u32 currvid, currfid;
> + u32 currpstate;
Any reason why it has been moved to a separate line? (either split all
fields or keep them all together)
> +#define INVALID_HW_PSTATE 0xff
Please use an enum, not a define in the middle of a struct.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/