Re: [PATCH 06/10] x86: add check code for map/unmap_sg code
From: Ingo Molnar
Date: Fri Nov 21 2008 - 12:11:31 EST
* Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> + ret = ops->map_sg(hwdev, sg, nents, direction);
stray double space in '= ops'.
another very small detail:
> + unsigned long flags;
> + struct dma_debug_entry *entry;
> + struct scatterlist *s;
> + int i;
please order them like this, similar to the include line:
> + struct dma_debug_entry *entry;
> + struct scatterlist *s;
> + unsigned long flags;
> + int i;
that makes the whole variable section non-intrusive. (and also acts as
a patch-conflict-reducer mechanism in the future - when variable
definition lines get particularly long)
(not a hard rule, exceptions are possible - grouping same-type fields
together, etc.)
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/