Re: [PATCH 1/2] kvm: use modern cpumask primitives, no cpumask_ton stack

[Avi Kivity]

Mike Travis wrote:
> > Since we're in a get_cpu() here, how about a per_cpu static cpumask
> > instead? I don't mind the inefficient fallback, just the duplication.
> >     
>
> One thing to note is that when CPUMASK_OFFSTACK=n, then alloc_cpumask_var
> returns a constant 1 and the duplicate code is not even compiled.
>   

I'm a lot more concerned about source duplication than binary 
duplication.  Rusty's patches resulted in a net reduction in 
duplication, so perhaps I should keep quiet about it.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/