Re: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c

[Ingo Molnar]

* Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:

> Impact: Fix compilation warning.
> 
>  CC      arch/x86/kernel/paravirt-spinlocks.o
> arch/x86/kernel/paravirt-spinlocks.c: In function `default_spin_lock_flags':
> arch/x86/kernel/paravirt-spinlocks.c:12: warning: passing arg 1 of
> `__raw_spin_lock' from incompatible pointer type
> 
> This patch fixes the above warning.  __raw_spin_lock(lock) is declared
> when CONFIG_SMP is defined. Thus, a call to __raw_spin_lock requires
> checking CONFIG_SMP is defined or not.
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
> 
> --- linux-2.6-orig/arch/x86/kernel/paravirt-spinlocks.c	2008-12-05
> 19:53:15.000000000 +0600
> +++ linux-2.6/arch/x86/kernel/paravirt-spinlocks.c	2008-12-07
> 23:52:59.000000000 +0600
> @@ -9,7 +9,9 @@
> 
>  static void default_spin_lock_flags(struct raw_spinlock *lock,
> unsigned long flags)
>  {
> +#ifdef	CONFIG_SMP
>  	__raw_spin_lock(lock);
> +#endif

no - this just works around the compiler warning.

Look at the real fix below i did some time ago. If you are into fixing 
warnings you should try tip/master, that has a ton of warning fixes 
already:

  http://people.redhat.com/mingo/tip.git/README

	Ingo

------------------------>