Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

[Jeff Garzik]

Jiri Slaby wrote:
> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
>
> Check if they are null and avoid checks in that case.
>
> Solves:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230
>
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: Jeff Garzik <jgarzik@xxxxxxxxxx>
> Cc: Alexandru Romanescu <a_romanescu@xxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/ata/ata_piix.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

Note that the original version of this patch went upstream last night...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/