Re: [PATCH] rewrite the return method of static ints3c24xx_spi_setup(struct spi_device *spi) indrivers/spi/spi_s3c24xx.c
From: Jianjun Kong
Date: Wed Dec 10 2008 - 00:26:24 EST
On Wed, Dec 10, 2008 at 11:01:51AM +0800, Helight.Xu wrote:
>rewrite the return method of static int
>s3c24xx_spi_setup(struct spi_device *spi)
>in drivers/spi/spi_s3c24xx.c
>
>reason:
>s3c24xx_spi_setupxfer(spi, NULL) return 0 or -EINVAL,
>so here shoud return the ret,but only 0.
The original code can return the correct value.
It contains 0 and -EINVAL, not only 0. So this change is not essential.
--
Jianjun Kong |Happy Hacking
Homepage: http://kongove.cn
Gtalk:KongJianjun@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/