Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback fromalloc_large_system_hash

[Dave Hansen]

On Wed, 2008-12-10 at 18:27 +0000, Catalin Marinas wrote:
> 
> @@ -4570,6 +4571,8 @@ void *__init alloc_large_system_hash(const char *tablename,
>         if (_hash_mask)
>                 *_hash_mask = (1 << log2qty) - 1;
>  
> +       memleak_alloc(table, size, 1, GFP_ATOMIC);
> +
>         return table;
>  }

Why is this sucker GFP_ATOMIC?

Since alloc_large_system_hash() is using bootmem (and is called early),
I'm a little surprised that it is OK to call into memleak_alloc() which
uses kmem_cache_alloc().  Is the slab even set up at this point?

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/