Re: [PATCH] Do not pass the SLAB flags as GFP in slobkmem_cache_create

From: Cyrill Gorcunov
Date: Wed Dec 10 2008 - 15:27:48 EST


[Christoph Lameter - Wed, Dec 10, 2008 at 02:11:23PM -0600]
| On Wed, 10 Dec 2008, Cyrill Gorcunov wrote:
|
| > this would make the following line in slob_alloc
| >
| > ...
| > if (unlikely((gfp & __GFP_ZERO) && b))
| > memset(b, 0, size);
| > ...
| >
| > useless. Not sure if it will be good :)
|
| No. GFP_ZERO is set when kmalloc etc is called. Its not set on
| kmem_cache_create.
|

yep, Matt already pointed, I just missed first time.

- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/