Re: [RFC][PATCH 3/3] CGroups: Add css_tryget()

From: KAMEZAWA Hiroyuki
Date: Thu Dec 11 2008 - 02:30:44 EST


On Wed, 10 Dec 2008 23:28:12 -0800
Paul Menage <menage@xxxxxxxxxx> wrote:

> On Wed, Dec 10, 2008 at 9:15 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> >
> > Could you add this ?
> > ==
> > bool css_is_removed(struct cgroup_subsys_state *css)
> > {
> > return test_bit(CSS_REMOVED, &css->flags);
> > }
> > ==
> > Then, I'll use this instead of memcg->obsolete flag.
>
> I actually had a patch almost ready to send out the nuked memcg->obsolete.
>
> A difference in mine is that I did
>
> #define css_is_removed(__css) test_bit(CSS_REMOVED, &(__css)->css.flags)
>
> so that you can use it on any subsystem state object that contains a
> "struct cgroup_subsys_state css;" field, which is currently all of
> them I think, without having to add the "->css" every time.
>
ok, thx. very useful :)

-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/