Re: [PATCH] x86, bts: fix build error

[Ingo Molnar]

* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@xxxxxxx] 
> >Sent: Freitag, 12. Dezember 2008 08:23
> >To: Metzger, Markus T
> 
> > i fixed a build failure via the commit below - but the recursion in 
> > that code is really nasty. Could you please clean it all up to plain 
> > flat code?
> 
> Sure.
> 
> How could I find those things myself? Gcc 4.3.0 does not even give a 
> warning for a defconfig build. Is there a config option I should set?

Gcc 4.3.0 is too new for that build failure ;-) -tip testing involves 
testing with a couple of older compilers as well. This failure was with 
4.2.2 iirc.

You generally shouldnt worry about that too much, as long as it built 
fine on your config and the code is reasonably clean.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/