Re: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c

[Ingo Molnar]

* Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:

> On 12/8/08, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> >  * Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:
> >
> > no - this just works around the compiler warning.
> >
> >  Look at the real fix below i did some time ago. If you are into fixing
> >  warnings you should try tip/master, that has a ton of warning fixes
> >  already:
> >
> >   http://people.redhat.com/mingo/tip.git/README
> >
> >         Ingo
> Thanks, Ingo for explanation. In 'default_spin_lock_flags' function ,
> the 2nd argument unsigned long flags isn't used in the function. Is it
> necessary to keep it ?

yes, it's a function pointer used in a generic template:

        .spin_lock_flags = default_spin_lock_flags,

.spin_lock_flags() expects that parameter signature - even if in specific 
implementations the parameter might be unused.

	Ingo

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/