Re: [PATCH] block: Fix LSF default inconsistency

[Jens Axboe]

On Fri, Dec 12 2008, Jean Delvare wrote:
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index 1d98330..121f349 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -135,19 +135,14 @@ typedef		__s64		int64_t;
> >   *
> >   * Linux always considers sectors to be 512 bytes long independently
> >   * of the devices real block size.
> > + *
> > + * blkcnt_t is the type of the inode's block count.
> >   */
> 
> You might want to edit the start of this comment a bit, as it currently
> says "The type used for...". You probably want instead "sector_t is the
> type...". And drop the extra "*" while you're here, as this is a
> regular comment and not a kerneldoc thing.

Agree, that'll make it cleaner. I'll make those changes next time I have
to shuffle the patches.

> >  #ifdef CONFIG_LBD
> >  typedef u64 sector_t;
> > -#else
> > -typedef unsigned long sector_t;
> > -#endif
> > -
> > -/*
> > - * The type of the inode's block count.
> > - */
> > -#ifdef CONFIG_LSF
> >  typedef u64 blkcnt_t;
> >  #else
> > +typedef unsigned long sector_t;
> >  typedef unsigned long blkcnt_t;
> >  #endif
> >  
> 
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

Thanks, I added your Acked-by.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/