Re: [PATCH 1/2] video: mbp_nvidia_bl: Add support for MacBook 5, MacBook Air 2, and MacBook Pro 5

[Matthew Garrett]

On Fri, Dec 12, 2008 at 09:48:51PM +0100, Mario Schwalbe wrote:

> Known Bugs:
>     * MacBook Pro 5:
>          Initial brightness after bootup is the last recently used
>          brightness (in Mac OSX), while the firmware reports maximum.
>          Impossible to fix.

In that case, why not read the firmware value and then set that 
explicitly on driver load? Having the driver be in sync with the 
hardware is better than avoiding a brightness change on boot.

> +static int intel_chipset_get_intensity(struct backlight_device *bd)
>  {
>  	outb(0x03, 0xb3);
>  	outb(0xbf, 0xb2);
>  	return inb(0xb3) >> 4;
>  }

Just to absolutely clarify, this is intel chipset as in motherboard 
chipset and not graphics chipset, right? A comment to make that clear 
would be good - it left me a little confused at first. Other than that, 
it looks good.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/