Re: [PATCH 3/4] ieee1394: mark bus_info_data was a __be32 array

From: Stefan Richter
Date: Sat Dec 13 2008 - 19:38:30 EST


Harvey Harrison wrote:
> Two access functions get_max_rom and set_hw_config_rom are
> changed to take __be32 as well. Only bus_info_data was
> ever passed in so this is OK. All other uses of bus_info_data
> treated it as a be32 value already.

I pushed the following out to linux1394-2.6.git:

Harvey Harrison (6):
ieee1394: pcilynx: trivial endian annotation
ieee1394: replace CSR_SET_BUS_INFO_GENERATION macro
ieee1394: mark bus_info_data as a __be32 array
ieee1394: eth1394: trivial sparse annotations
ieee1394: dv1394 annotate frame input/output structs as little endian
ieee1934: dv1394: interrupt enabling/disabling broken on big-endian

Note, I dropped two hunks from "mark bus_info_data..." due to another
change which I posted only a few hours ago. Please check:
http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=d88b81b772c6db76eb3b9f9564034f55d0dcdd09
This interfered with your patch:
http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=6b09b72cbdcba8da71b85651eb37e0156aa65def

I pulled your patches into my master branch but not yet into my for-next
branch (awaiting possible feedback on what I enqueued before your patches).
--
Stefan Richter
-=====-==--- ==-- -===-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/