Re: [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl

From: Andi Kleen
Date: Sun Dec 14 2008 - 10:01:44 EST


> -#define KMALLOC_SIZE_MIN 4096 /* 4KB */
> -#define KMALLOC_SIZE_MAX 131072 /* 128 KB */
> +#define NILFS_IOCTL_KMALLOC_SIZE 8192 /* 8KB */

Better would be if you could go to PAGE_SIZE. order 0 allocations
are typically the fastest / least likely to stall.

Also in this case it's a good idea to use __get_free_pages()
directly, kmalloc tends to be become less efficient at larger
sizes.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/