Re: [PATCH] rt/workqueue: fix an early crash and some warnings

[Steven Rostedt]

On Sun, 14 Dec 2008, Frederic Weisbecker wrote:

> Impact: fix early crash and build warnings
> 
> While building the broken/rt/workqueue topic, I got various warnings:
> 
> kernel/workqueue.c: In function ?delayed_work_timer_fn?:
> kernel/workqueue.c:214: attention : passing argument 3 of ?__queue_work? makes integer from pointer without a cast
> 
> This one is the cause of an early crash: the adress of the priority is passed instead of its
> value, hence the following BUG_ON() triggering on sched.c:rt_mutex_setprio()
> 
> BUG_ON(prio < 0 || prio > MAX_PRIO)
> 
> Various warnings are displayed because of confusion between common linked-list and priority
> sorted linked-list:
> 
> kernel/workqueue.c: In function ?flush_work?:
> kernel/workqueue.c:527: attention : passing argument 1 of ?list_empty? from incompatible pointer type
> kernel/workqueue.c:535: attention : assignment from incompatible pointer type
> kernel/workqueue.c:539: attention : assignment from incompatible pointer type
> 
> This patch fixes them (hopefully correctly).
> 
> broken/rt/workqueue boots correctly now.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Thanks! I'll give this a try on Monday.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/