Re: [PATCH] avoid unnecessary assignment in lookup_bdev()

[Greg KH]

On Mon, Dec 15, 2008 at 02:33:20AM +0800, Coly Li wrote:
> In normal cases, lookup_bdev() should return successfully, therefore it's not a good idea to always
> assign error values before checking truth/false conditions. This patch modifies code to only assign
> error value in necessary false conditions.
> 
> If I missed something, please correct me.

I don't understand, is there some way that the current code could
incorrectly return an error value?

Is your change somehow faster?  I don't think this is on any fast-path
code, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/