PATCH: mvsas: increase port type detection delay to suit Seagate's15k6 drive ST3450856SS 0003

From: Reinhard Nissl
Date: Sun Dec 14 2008 - 17:50:28 EST


Hi Greg,

I hope you don't mind following your suggestion:

> Also, please cc: the stable developers if you want them to pay attention
> to messages like this.

-------- Original-Nachricht --------
Betreff: Re: PATCH: mvsas: increase port type detection delay to
suit Seagate's 15k6 drive ST3450856SS 0003
Datum: Fri, 12 Dec 2008 21:23:45 +0100
Von: Reinhard Nissl <rnissl@xxxxxx>
An: linux-scsi@xxxxxxxxxxxxxxx
CC: Ke Wei <kewei@xxxxxxxxxxx>, Jeff Garzik
<jgarzik@xxxxxxxxxx>, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Referenzen: <493BC76F.3060105@xxxxxx> <49405137.9000902@xxxxxx>

Hi,

I wonder why no one has dropped me a line so far. I hope you
don't mind CCing you directly. I found your email addresses on
mailing list entries regarding mvsas. I attach the little patch
again for ease of use.

Reinhard Nissl schrieb:

> I increased the delay step by step until loading of mvsas
> reliably detected the drive 200 times in sequence. A much better
> approach would be to monitor the hardware for some flag which
> indicates that port detection has finished, but I do not have any
> hardware documentation.
>
> BTW: patch is against
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git
>
> Signed-off-by: Reinhard Nissl <rnissl@xxxxxx>

Bye.
--
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl@xxxxxx
diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index 1dd70d7..23e5a87 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2959,7 +2959,7 @@ static int __devinit mvs_hw_init(struct mvs_info *mvi)

/* enable auto port detection */
mw32(GBL_PORT_TYPE, MODE_AUTO_DET_EN);
- msleep(100);
+ msleep(1100);
/* init and reset phys */
for (i = 0; i < mvi->chip->n_phy; i++) {
u32 lo = be32_to_cpu(*(u32 *)&mvi->sas_addr[4]);