Re: [rtc-linux] Re: [PATCH 4/7] rtc: PCF50633 rtc driver

[Balaji Rao]

On Sun, Dec 14, 2008 at 11:21:28PM +0100, Alessandro Zummo wrote:
> On Mon, 15 Dec 2008 03:34:30 +0530
> Balaji Rao <balajirrao@xxxxxxxxxxxx> wrote:
> 
> > Hmm. This patch is included in [PATCH 1/7] of the series - which
> > implements the core driver. This core driver needs this file to compile
> > and not including there is going to break the bisectability of the
> > series. Isn't this what I'm supposed to do ? Please correct me if I'm
> > wrong.
> 
>  ok, then don't break.
>  

OK, thinking more about this, I realised that this series, has to be
taken in together, as rtc-pcf50633.c alone wouldn't compile for you..

Probably it could be taken into the MFD tree once you ACK this ? I don't
know.. If this is not a problem at all, please feel free to ignore me!

> > > > +	pcf = platform_get_drvdata(pdev);
> > > 
> > >  uh? where did you set up the pointer?
> > > 
> > > 
> > > > +	/* Set up IRQ handlers */
> > > > +	pcf->irq_handler[PCF50633_IRQ_ALARM].handler = pcf50633_rtc_irq;
> > > > +	pcf->irq_handler[PCF50633_IRQ_SECOND].handler = pcf50633_rtc_irq;
> > > > +
> > > > +	pcf->rtc.rtc_dev = rtc;
> > > 
> > >  ??
> > > 
> > 
> > It's done in the core driver - [PATCH 1/7] of this series.
> 
>  mm. that's strange. a platform driver is supposed to receive informational
>  structures (regions, irqs, ...) and init driver data by itself. you shouldn't need
>  to mess with the drvdata pointer.
> 

Oh, ok. I now see how I can do better. Will wait for comments for the
rest of the series and post a improved version.

>  I do not also feel fine with the irq handlers setup. Your core should export
>  a function for irq registration.
>

Yes, ok.
 
> > Thank you for the review. Will send again after resolving the issues.
> 
>  thanks for your contribution. you are doing great things at openmoko.
> 

You're welcome.

	- Balaji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/