Re: [PATCH] mfd: DA9030 USB charge pump mode selection support

[Mark Brown]

On Mon, Dec 15, 2008 at 11:01:47AM +0200, Mike Rapoport wrote:
> Jonathan Cameron wrote:

> > The main question on this is whether it should just be rolled into
> > the core mfd driver.  I'm inclined to keep it separate and decidedly
> > optional as the fact it isn't already in the driver implies that
> > it may not be commonly used. (Intel Stargate 2 does need this
> > functionality though, hence the submission as I'm hoping to get
> > the relevant board code in soonish.)

> I'm for adding "da9030_set_usb_charge_pump_mode" to the core mfd driver.

Me too - if there are concerns about kernel size a config option could
be added to allow users to select it.  Unless we get an abstraction for
these USB power sources (which might be useful) a separate driver
doesn't seem to buy much.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/