Re: [PATCH] sched: fix another race when reading /proc/sched_debug

[KAMEZAWA Hiroyuki]

On Mon, 15 Dec 2008 11:43:49 +0100
Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> > +                if (cgroup_is_removed(cgroup) || !cgroup->dentry)
> > +                        return;
> >  		cgroup_path(cgroup, path, sizeof(path));
> > +	}
> 
> Perhaps wrap that check in a cgroup_*() helper? That would avoid the
> duplication, be clearer and not open code the ->dentry assumption.
> 
> cgroup_is_active() perhaps?
> 

I vote for cgroup_is_populated().

Thx,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/