Re: [PATCH 7/7] regulator: PCF50633 pmic driver

[Mark Brown]

On Sun, Dec 14, 2008 at 04:34:00PM +0530, Balaji Rao wrote:

> +struct regulator_ops pcf50633_regulator_ops = {
> +	.set_voltage = pcf50633_regulator_set_voltage,
> +	.get_voltage = pcf50633_regulator_get_voltage,
> +	.enable = pcf50633_regulator_enable,
> +	.disable = pcf50633_regulator_disable,
> +	.is_enabled = pcf50633_regulator_is_enabled,
> +	.set_suspend_enable = pcf50633_regulator_enable,
> +	.set_suspend_disable = pcf50633_regulator_disable,
> +};

Are you sure that the suspend variants of the operations should be the
same as the regular versions?

> +struct platform_driver pcf50633_regulator_driver = {
> +	.driver = {
> +		.name = "pcf50633-regltr",
> +	},
> +	.probe = pcf50633_regulator_probe,
> +	.remove = __devexit_p(pcf50633_regulator_remove),
> +};

Not that it matters too much but I have a hard time liking "regltr".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/