Re: [patch] Performance Counters for Linux, v4

[Paul Mackerras]

Ingo Molnar writes:

> We are pleased to announce the v4 release of our performance counters 
> subsystem implementation.

Looking at the code, I am wondering what you are planning to do to
support machines that have constraints on what sets of events can be
counted simultaneously.  Currently you have the core code calling
counter->hw_ops->hw_perf_counter_enable which can't return an error.
The core expects it to be able to add any counter regardless of what
event it's counting, subject only to a maximum number of counters.
I assume you're going to change that.

I think the core should put together a list of counters and counter
groups that it would like to have on the PMU simultaneously and then
make one call to the arch layer to ask if that is possible.  That
could either return success or failure.  If it returns failure then
the core needs to ask for something less, or something different.  I'm
not sure how the core should choose what to ask for instead, though.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/