Re: [PATCH] Check return from argv_split() in do_coredump().

[Tetsuo Handa]

Hello.

Américo Wang wrote:
> How about going to the line:
> 
>         current->fsuid = fsuid;
> 
> ? Because when argv_split() fails, helper_argv is NULL and doesn't need
> to be checked again.

I didn't understand what you say. I'm saying that
"do_coredump() may accesss helper_argv[0] when helper_argv == NULL",
which will result in "NULL pointer dereference" problem.
Yes, this problem unlikely happens. Thus,

if (!helper_argv)
	goto fail_unlock;

may be enough.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/