Re: [PATCH] AMD Geode CS553X GPIO driver

[David Brownell]

On Friday 26 December 2008, Alessandro Zummo wrote:
> > >  It uses the gpio framework and the gpio api as defined in
> > >  arch/x86/kernel/geode_32.c
> > 
> > Eventually I'd hope to see those geode_32.c calls just vanish.
> > 
> > In fact, the "normal" way to package these GPIOs would be to
> > always provide them through the standard API, in arch/... code,
> > with no Kconfig option.  Any reason you shouldn't do that in
> > this patch?
> 
>  I didn't want to mess with something I did not wrote.

Such messing is part'n'parcel of updating the kernel though.  :)


>  Maybe a two steps 
>  approach can convince people to move on ;) (you remember what happened
>  with people holding their old rtc code tight :) )

The RTC case was different ... driver structure needed to
either use the new framework, or the old.  Except for that
drivers/rtc/rtc-ppc.c migration aid, letting some of them
coexist until the older ppc_md stuff gets updated.  That is,
switching from one full-fledged driver to another one needs
some kind of scheduled flag day.  (Plus completing kernel
infrastructure, of which NTP support is probably the most
significant missing part right now.)

If you add this to the geode_32.c file it'll just provide a
standard interfaces, which can coexist with the older stuff
until it's removed.  Several of the ARM platforms have
exactly that kind of coexistence going on.  (Example, OMAP;
which in 2.6.29 will stops using its legacy GPIO calls.)

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/