Re: [PATCH] x86_64: Eliminate atleast 10684 sparse warnings

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, 27 Dec 2008 15:21:36 +0530 Jaswinder Singh Rajput <jaswinder@xxxxxxxxxxxxx> wrote:
> 
> >  #ifdef CONFIG_ILLEGAL_POINTER_VALUE
> > -# define POISON_POINTER_DELTA CONFIG_ILLEGAL_POINTER_VALUE
> > +# define POISON_POINTER_DELTA _AC(CONFIG_ILLEGAL_POINTER_VALUE, UL)
> >  #else
> >  # define POISON_POINTER_DELTA 0
> >  #endif
> 
> So now
> 
> commit 948f984df52511bb0efa5c026813b0c34de43aa0
> Author:     Avi Kivity <avi@xxxxxxxxxxxx>
> AuthorDate: Tue May 20 14:39:25 2008 +0300
> Commit:     Ingo Molnar <mingo@xxxxxxx>
> CommitDate: Tue May 20 13:42:31 2008 +0200
> 
>     core, x86: make LIST_POISON less deadly
> 
> gets splattered across three commits (at least).  Sigh.

Can rebase, although that would hide the (deserved) credit that 
Jaswinder's patch deserves. And it does not appear to be a must-rebase 
example to me - it's not like one does sparse builds during bisection.

> (how come that patch is 7 moonths old and still unmerged, btw?)

Linus had reservations about the first version (which got fixed but which 
prevented it from going upstream in the first cycle) - and it's not an 
exactly critical change and other stuff interfered. All our previous merge 
windows were fully filled ;)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/